fix deprecated warning for action graph APIs.#1188
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
There was a problem hiding this comment.
Pull request overview
Updates ros2cli’s internal graph API usage for action discovery to avoid deprecation warnings introduced by rclpy changes (follow-up to ros2/rclpy#1574), aligning ros2cli/daemon and direct node strategies with the newer rclpy.node.Node action graph APIs.
Changes:
- Switch
DirectNodeaction graph helpers fromrclpy.action.*toNode.get_action_*methods. - Update daemon XML-RPC function registration to use
node.get_action_*methods directly (removing the need forbind()andrclpy.actionimports).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ros2cli/ros2cli/node/direct.py | Removes deprecated rclpy.action graph calls and delegates to Node action graph methods. |
| ros2cli/ros2cli/daemon/init.py | Registers daemon XML-RPC action graph APIs via node methods, eliminating deprecated rclpy.action usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
@ahcorde i just missed this one during ros2/rclpy#1574, can you review this?
|
Pulls: #1188
|
Description
follow up of ros2/rclpy#1574
Fixes #1187
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information